Update samples for v4 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for v4: - output_type_id_params no longer has the is_required property tidying: - smart quotes are replaced with ASCII - tabs are replace with spaces - JSON examples are aligned properly and the relevant lines highlighted
This gives the table clear column and row headers, so that it is accessible by a screen reader (and easier to visually parse)
elray1
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not fix #169, but it addresses the
is_requiredelement for v4 along with minor improvements:Preview: https://hubdocs--223.org.readthedocs.build/en/223/user-guide/sample-output-type.html